[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-28 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1487699945 @cadonna Thanks for your comments. I've addressed your comments except the nit name. LMK what do you think as a better name for the class `TaskAndAction` and I can change the

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-16 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1472840025 > I triggered one now: https://jenkins.confluent.io/job/system-test-kafka-branch-builder//console @lucasbru the failure seems not related to the code but sock timeouts

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-16 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1472839086 ping @cadonna for a final look, this PR needs to go first before the next one. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-07 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1458570328 @lucasbru did you happen to have triggered a system test for this branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-03 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1453957529 > We had a failure of Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true. I'm pretty sure that one was not flaky before. Any

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-02 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1452793608 SmokeTestDriverIntegrationTest did not fail in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/11, triggering again. If that run still did not fail

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-02 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1452549269 `SmokeTestDriverIntegrationTest` did not fail in `https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/2`, triggering again. -- This is an automated message from the