[GitHub] [kafka] hachikuji commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
hachikuji commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434702023 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,90 @@ class ControllerContext { partitionsForTopic(topic

[GitHub] [kafka] hachikuji commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434262971 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1254,23 +1254,7 @@ class KafkaController(val config: KafkaConfig, i

[GitHub] [kafka] hachikuji commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434262971 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1254,23 +1254,7 @@ class KafkaController(val config: KafkaConfig, i