[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-08 Thread via GitHub
hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1100465745 ## generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java: ## @@ -411,7 +409,7 @@ private void generateListenerTypesEnum() { } priv

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-07 Thread via GitHub
hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1099052637 ## generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java: ## @@ -408,6 +410,23 @@ private void generateListenerTypesEnum() { buffer.p

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-06 Thread via GitHub
hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1098020205 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3509,6 +3510,13 @@ class KafkaApis(val requestChannel: RequestChannel, ) } + def handleConsum

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-06 Thread via GitHub
hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1098014628 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) { return

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-03 Thread via GitHub
hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1096118406 ## clients/src/main/java/org/apache/kafka/common/protocol/Errors.java: ## @@ -372,7 +375,10 @@ public enum Errors { FETCH_SESSION_TOPIC_ID_ERROR(106, "The fetch