[GitHub] [kafka] hachikuji commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-03 Thread via GitHub
hachikuji commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1184131575 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -637,17 +637,31 @@ class ReplicaManager(val config: KafkaConfig, if (isValidRequiredAcks(required

[GitHub] [kafka] hachikuji commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread via GitHub
hachikuji commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1183173661 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,8 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet ve