[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-07-06 Thread via GitHub
hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1624048937 Committed the suggestions, thanks again for reviewing @C0urante! BTW, I also opened https://github.com/apache/kafka/pull/13951 to have `WorkerSinkTaskThreadedTest` migrated. Ther

[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-06-04 Thread via GitHub
hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1575746499 Thanks @C0urante for your thoroughly review! I think I've addressed all your comments. I've also picked up the work to have the `WorkerSinkTaskTest` migrated next (this one is

[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-04-24 Thread via GitHub
hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1521090615 Thanks for your feedback @C0urante. I finally had time this past week and tweaked the test to address your comments and fix coverage. -- This is an automated message from th

[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-03-26 Thread via GitHub
hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1484321402 > Thanks @hgeraldino! I've made it about halfway through in this pass; will try to revisit this week or the next and look at the rest. > > Also, similar to [#13191 (comment)](ht