[GitHub] [kafka] hgeraldino commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-09-25 Thread via GitHub
hgeraldino commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1734640996 > Thanks for the updates @hgeraldino, the build looks good now. My apologies for not noticing these earlier, but I just had a couple more minor comments. This should be good to be merg

[GitHub] [kafka] hgeraldino commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-09-23 Thread via GitHub
hgeraldino commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1732369824 > @hgeraldino the Connect integration tests are failing with errors like: Thanks @yashmayya, adding entries for the new converter to the metadata fixed the build issues 👍 --

[GitHub] [kafka] hgeraldino commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-08-16 Thread via GitHub
hgeraldino commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1681170703 > Thanks @hgeraldino, LGTM! I just had a few more minor suggestions. Addressed the second round of comments. Thanks again! -- This is an automated message from the Apache Git S

[GitHub] [kafka] hgeraldino commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-08-11 Thread via GitHub
hgeraldino commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1674897648 Thanks @yashmayya for your review! I addressed your comments, please take another look when you have a chance -- This is an automated message from the Apache Git Service. To re