[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471469700 > > In addition, does this repair need to open a new jira? > > In fact, we should revert this PR first. The solution offered by this PR bring antoher issue (thanks to @robobario). Th

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471460665 > > > If all variables are volatile or atomic, will it affect the printing performance of this perf program? > > Or we just handle the `iteration` as it seems `iterat

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471428193 > > Maybe my thread safety explanation is incorrect, I'll look again tomorrow. > > the thread safety explanation is correct to me. My point was that we should not only fix `iteratio

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471416257 > In fact, I also have this question. The variables in stats are all thread-unsafe at present, but the printed data looks fine😂, and this is a probabilistic problem for the version

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471374895 > Hi, I think this introduced a race condition that can cause the producer-perf-test to log a lot of exceptions to console if num records > 50. Since the `iteration` is incremented fro

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1470060354 Thx, Is this [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-842%3A+Add+richer+group+offset+reset+mechanisms) interested in understanding and discussing? @chia7712 @showuon

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1463470303 > Hello, the relevant test code has been submitted, please help to review, thank you. @showuon -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1463200864 > @hudeqi , thanks for the patch. This change makes sense to me. Could you add tests for this change? Do you want to add test screenshots/results for this case, or the test code cor

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1463199545 > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1463199231 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1458087082 Can someone take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen