huxihx opened a new pull request #9399:
URL: https://github.com/apache/kafka/pull/9399


   https://issues.apache.org/jira/browse/KAFKA-10584
   
   In Scala, we prefer sealed traits over Enumeration since the former gives 
you exhaustiveness checking. With Scala Enumeration, you don't get a warning if 
you add a new value that is not handled in a given pattern match.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to