[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-25 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r563455980 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-24 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r563460396 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -529,15 +518,14 @@ class KafkaApisTest { new

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-24 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r563459295 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -227,37 +225,33 @@ class KafkaApisTest { authorizeResource(authorizer,

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-24 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r563455980 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-20 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561002429 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java ## @@ -175,4 +175,19 @@ public String clientId() { public int

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-19 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r560345597 ## File path: core/src/main/scala/kafka/server/RequestHandlerHelper.scala ## @@ -58,16 +57,68 @@ object RequestHandlerHelper { } } +class

[GitHub] [kafka] ijuma commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-16 Thread GitBox
ijuma commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r558921130 ## File path: core/src/main/scala/kafka/server/RequestHandlerHelper.scala ## @@ -58,16 +57,68 @@ object RequestHandlerHelper { } } +class