[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102976553 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -0,0 +1,676 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102975376 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProducer

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102882346 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness { // get here wit

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102882346 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness { // get here wit

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102842008 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProducer

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101481342 ## core/src/test/scala/unit/kafka/log/LogTestUtils.scala: ## @@ -247,7 +246,7 @@ object LogTestUtils { } def listProducerSnapshotOffsets(logDir: File): Seq[Long]

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101480397 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,20 +680,20 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProducer

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095387492 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1071365497 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -2104,7 +2105,7 @@ object UnifiedLog extends Logging { // (or later snapshots). Otherwise, if there is no sn

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1071361752 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the intermedi