[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-04-05 Thread via GitHub
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1158577698 ## clients/src/main/java/org/apache/kafka/common/utils/BytesStreamBufferSource.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-01-23 Thread via GitHub
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084344515 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -273,20 +272,32 @@ public int partitionLeaderEpoch() { public DataInputStream

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-01-23 Thread via GitHub
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084344515 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -273,20 +272,32 @@ public int partitionLeaderEpoch() { public DataInputStream

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-01-20 Thread GitBox
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1082623877 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream buffer,

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-01-20 Thread GitBox
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1082622801 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream buffer,

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-01-20 Thread GitBox
ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1082588469 ## clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java: ## @@ -62,10 +68,11 @@ public void release(ByteBuffer buffer) { }