[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

2023-03-02 Thread via GitHub
ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1124016717 ## storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java: ## @@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

2023-02-28 Thread via GitHub
ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1120933708 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

2023-02-28 Thread via GitHub
ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r112095 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o