[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-06-20 Thread via GitHub
ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1236054069 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java: ## @@ -431,7 +431,7 @@ private static void skipBytes(InputStream in, int bytesToSkip) throws

[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-06-20 Thread via GitHub
ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1236050527 ## clients/src/main/java/org/apache/kafka/common/serialization/ShortDeserializer.java: ## @@ -34,7 +34,7 @@ public Short deserialize(String topic, byte[] data) {

[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-06-10 Thread via GitHub
ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1225487332 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -128,11 +128,11 @@ public InputStream wrapForInput(ByteBuffer buffer, byte messageVer

[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-04-18 Thread via GitHub
ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1170050264 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -434,7 +434,7 @@ private static byte computeAttributes(CompressionType type, Times