[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1441082213 @dejan2609 Good catch. I fixed it in the same branch. And tested with Scala 2.12 and 2.13. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1440767080 @dejan2609 I added a few cleanups here: https://github.com/ijuma/kafka/commit/9c6ae575276e673f39d188d42a332f9f0b07d2d0 If you agree with them, please integrate into your PR. --

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439267357 @inglor Thanks. The following comment explains that the way `-release` must be set is a bit specific: https://github.com/gradle/gradle/issues/23962#issuecomment-1437348400 -- This

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1439211043 Thanks @dejan2609. I still prefer the path I described here: > https://github.com/gradle/gradle/issues/23962#issuecomment-1439115365 Do you know if that works? -- This is an

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1433081403 Yeah, that's a security feature. I suggest filing a JIRA about disabling spotlessScalaCheck with the rationale and have a single PR for that change. -- This is an automated message from

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1431655901 An alternative would be to drop spotless until we drop support for Java 8 (Apache Kafka 4.0). What actually uses spotless today? -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1430621318 Gradle 8 has been released. Have you been able to figure out why the build is failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1419776869 @dejan2609 We'll wait for the final release, but it's fine to start working through the issues. Looks like the build failed. -- This is an automated message from the Apache Git Service.