[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it

2021-01-23 Thread GitBox
ijuma commented on pull request #9925: URL: https://github.com/apache/kafka/pull/9925#issuecomment-766143833 @chia7712 Does this look ok to you? I am interested in making `unitTest` fast, so would like to get this merged. Th

[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it

2021-01-22 Thread GitBox
ijuma commented on pull request #9925: URL: https://github.com/apache/kafka/pull/9925#issuecomment-765241792 I removed the @FunctionalInterface annotation from `Invariant`. I don't think this interfaces are used as functional interfaces and they make the system more strongly typed. `Action

[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it

2021-01-22 Thread GitBox
ijuma commented on pull request #9925: URL: https://github.com/apache/kafka/pull/9925#issuecomment-765239810 @chia7712 What are you suggesting instead of `Validation` and `Invariant`? This is an automated message from the Apa