[GitHub] [kafka] ijuma commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

ijuma commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766742269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

ijuma commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766789111 JDK 11 build passed, JDK 8 and 15 had unrelated flaky failures. This is an automated message from the Apache Git Ser

[GitHub] [kafka] ijuma commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

ijuma commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766744182 Hmm, we may need to keep `Struct` as a type for `Schema`, however. So you may be right that we can only remove the serialization/deserialization methods. --

[GitHub] [kafka] ijuma commented on pull request #9960: MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes

ijuma commented on pull request #9960: URL: https://github.com/apache/kafka/pull/9960#issuecomment-766742269 @dengziming Looks like `StickyAssignor` also uses `Struct` still. Once all usages are removed, maybe we can delete `Struct` altogether instead of only some methods in it.