[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1028803896 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -184,6 +195,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.OFFSET_FETCH =>

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027051707 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1027036420 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1025980136 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -161,6 +166,12 @@ class KafkaApis(val requestChannel: RequestChannel, * Top-level method that handles

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1024713679 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel, } } + private def

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1024712573 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1023478149 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one