[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1167257449 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +149,23 @@ object TransactionLog { // Formatter for use with tools to read

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1167009340 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -683,8 +685,10 @@ class GroupMetadataManager(brokerId: Int, re

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-13 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165929989 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +152,23 @@ object TransactionLog { // Formatter for use with tools to read

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-13 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165928094 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -683,8 +685,10 @@ class GroupMetadataManager(brokerId: Int, re

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-13 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165922479 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1368,3 +1378,8 @@ case class GroupMetadataKey(version: Short, key: String) extends

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-13 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165919308 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1155,7 +1159,12 @@ object GroupMetadataManager { // version 2 refers to group