[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
jeffkbkim commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1262709064 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jeffkbkim commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261730522 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-11 Thread via GitHub
jeffkbkim commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1260529472 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInst