jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315804689
error from `testAlterReplicaLogDirs(String)`:
```
[2022-11-15 10:24:37,184] ERROR [ReplicaFetcher replicaId=2, leaderId=0,
fetcherId=0] Unexpected error occurred while processing d
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315591807
@dajac my bad, i was looking at the wrong test. it's related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1313140177
new test failures
```
ConsumerCoordinatorTest.testPrepareJoinAndRejoinAfterFailedRebalance
ProducerIdExpirationTest.testTransactionAfterTransactionIdExpiresButProducerIdRemains
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1306499515
@dajac thanks for the review, i have addressed the comments. i'm a bit
confused since the new parameterized replica fetcher test seems to be failing
in jdk 8 / scala 2.12
--
This is
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1302757888
@dajac thanks for the review. i have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1298996874
@dajac @showuon thanks for the review. i have addressed the feedback.
the biggest change is to only complete the purgatory when there is a change
in HWM
--
This is an automate
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1295299541
i've benchmarked the change in our internal infrastructure and stressed the
number of topic partitions. there were no noticeable differences (lock
contention/cpu/load) and confirmed the
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1292841267
thanks @showuon @dajac for the review. i have addressed the comments.
i am preparing a benchmark for the comparison.
--
This is an automated message from the Apache Git Service
