[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096076032 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096076032 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096074802 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096069586 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096068517 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.