jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-889393251
Thanks @vvcephei for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-856457128
Thanks @ableegoldman for your comments.
As far as I can tell after reading
https://issues.apache.org/jira/browse/KAFKA-12625, mostly the copyright files
were worked on,
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851831451
Thanks for looking at it @ableegoldman ,
I'll do my best explaining:
a) I added a NOTICE-binary file following the same pattern done for the
LICENSE patch. The purpose
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851594252
Hi @ableegoldman as you reviewed the last change in that area (fix license
files) do you think you can review this one? Thanks in advance!
--
This is an automated message from
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-845817871
@vvcephei As you were the last one touching that area, would you like to
review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841197433
Failures were https://issues.apache.org/jira/browse/KAFKA-9009 and
https://issues.apache.org/jira/browse/KAFKA-12629
--
This is an automated message from the Apache Git
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841123185
I would highly appreciate any hint on how to proceed for the dependencies
that do not include a notice file in their jar files but might include them in
their source code
