[GitHub] [kafka] jlprat commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2023-04-19 Thread via GitHub
jlprat commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1515213471 To the best of my knowledge, test failures seem to be all unrelated to the change in this PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jlprat commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2023-04-19 Thread via GitHub
jlprat commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1514217231 Hi @mimaison, the current unit tests present in the PR seem that they will cover the case of a potential involuntary regression for this feature. So I'm fine adding the change as it

[GitHub] [kafka] jlprat commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2023-04-18 Thread via GitHub
jlprat commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1512753339 Hi @mimaison! We have a variation (simplification) of this change running on our production for over a year and so far no problems. So I'd be fine with merging the change as it is.