[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076: Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926562692 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926217527 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926216992 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925972749 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925971253 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925969588 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925966739 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1474,7 +1482,7 @@ private void closeToError() { if (!setState(State.PENDING_ERROR)) {

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925960794 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1431,6 +1434,10 @@ private Thread shutdownHelper(final boolean error) { } private

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925895182 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1474,7 +1482,7 @@ private void closeToError() { if (!setState(State.PENDING_ERROR)) {

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925894827 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925809931 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925808463 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925805004 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925804504 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925804187 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r924957846 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r924957060 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r924785404 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r921566920 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software