[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670769638 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670658031 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -845,6 +887,7 @@ protected boolean retainTopic(String topic, boolean

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670630904 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -371,6 +372,43 @@ public void testUpdateLastEpoch() {

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670562472 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -874,18 +921,69 @@ protected boolean retainTopic(String topic,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670560488 ## File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java ## @@ -845,6 +887,7 @@ protected boolean retainTopic(String topic, boolean

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670559157 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670558097 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,36 @@ MetadataCache mergeWith(String newClusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670557719 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -69,13 +73,20 @@ private MetadataCache(String clusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670557519 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670553966 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -316,20 +325,29 @@ private MetadataCache

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670554176 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -216,6 +217,14 @@ public synchronized boolean updateRequested() {

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-15 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r670553369 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-14 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r669899334 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,30 @@ MetadataCache mergeWith(String newClusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-14 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r669815073 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -391,10 +393,15 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-13 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r669069127 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -391,10 +393,15 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-13 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r669065110 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -377,6 +397,12 @@ else if (metadata.error() ==

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-13 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r669064028 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,30 @@ MetadataCache mergeWith(String newClusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665654598 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -93,6 +104,14 @@ private MetadataCache(String clusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665652021 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -93,6 +104,14 @@ private MetadataCache(String clusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665649142 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,30 @@ MetadataCache mergeWith(String newClusterId,