jolshan commented on code in PR #13068:
URL: https://github.com/apache/kafka/pull/13068#discussion_r1062016540
##########
core/src/main/scala/kafka/log/ProducerStateManager.scala:
##########
@@ -502,6 +503,8 @@ class ProducerStateManager(
private var lastMapOffset = 0L
private var lastSnapOffset = 0L
+ newGauge("ProducerIdCount", () => producers.size)
Review Comment:
I think the other concern with this approach is that we have this metric per
ProducerStateManager (per partition!) when we really want it per broker.
https://github.com/apache/kafka/pull/13078 resolves this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
