[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136245326 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136221498 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136220531 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136148988 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136146308 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +335,10 @@ public String toString() { } } +public static

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

2023-03-06 Thread via GitHub
jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1126944890 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int throttleTimeMs,