[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939909 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939598 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939142 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-19 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171634759 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/AssignmentTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-19 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171629591 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-19 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171628212 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-19 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626917 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-19 Thread via GitHub
jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundati