[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-14 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263866826 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-14 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263865677 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263070668 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263069869 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263055145 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-13 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1263052783 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261758965 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261578373 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261559993 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2360,6 +2360,19 @@ public void testGroupIdsByTopics() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261559993 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2360,6 +2360,19 @@ public void testGroupIdsByTopics() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261554932 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261554932 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261521364 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261496901 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstan

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261492024 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstan

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261492024 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstan

[GitHub] [kafka] jolshan commented on a diff in pull request #13991: KAFKA-14462; [23/23] Wire GroupCoordinatorService in BrokerServer

2023-07-12 Thread via GitHub
jolshan commented on code in PR #13991: URL: https://github.com/apache/kafka/pull/13991#discussion_r1261475273 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -175,7 +176,7 @@ object Defaults { val ConsumerGroupMinHeartbeatIntervalMs = 5000 val ConsumerGroupMa