[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-11 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321818294 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-11 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321717776 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-11 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321714957 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-08 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320049614 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-08 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320046439 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-08 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320040698 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319107403 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319083998 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319082640 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319078377 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319008280 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319005551 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one