jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1611687116
Thanks for the review 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1610267331
I ran some tests with producer-perf. I didn't see noticeable differences,
but the tests were not particularly long. I can run more if needed. The
`--transaction-duration` argument tells h
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1610196155
Thanks for sharing this flame graph. I see that the histogram takes up the
majority of the processCompletedSends, but compared to the total cpu usage,
it's about 1%. I still think it is w
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1609874663
> Although one histogram calculation here should be ok, but it would be nice
if you get some producer-perf.sh data in as well to ensure that this metric
isn't adversely impacting latency.
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1607881974
The last builds are looking better. @divijvaidya please take a look when you
get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1603056522
I've updated the PR, but I'm seeing a thread leak in the tests, not sure if
that's just from trunk or my change. Will investigate.
--
This is an automated message from the Apache Git Se
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1590237911
unit.kafka.server.AddPartitionsToTxnManagerTest.testAddPartitionsToTxnManagerMetrics()
is failing. I was a bit worried this could be flaky. Will investigate.
--
This is an automated me
