jolshan edited a comment on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-814408153
~currently blocked on https://github.com/apache/kafka/pull/10492
(Need to add topic IDs to the metadata topic for fetching)~
No longer blocked
--
This is an
jolshan edited a comment on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-796886007
@chia7712 There was a lot of back and forth about whether we should simply
include the topic ID and the name in the protocol (to uniquely identify the
topic--which is
jolshan edited a comment on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-796317046
@chia7712 here's the commit. As mentioned in the commit message:
> Left a few todos. Still need to clean up, optimize code, and fix flaky and
broken tests in
jolshan edited a comment on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-776097476
>
> Also, it seems that for more partitions, the performance with this PR is
noticeably worse than trunk?
>
> ```
>
jolshan edited a comment on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-767987726
I'm aware that the latest changes to ensure the correct fetch version is
sent seem to be causing more test timeouts. Will need to investigate further
and hopefully
