[GitHub] [kafka] jsancio commented on a diff in pull request #13207: KAFKA-14664; Fix inaccurate raft idle ratio metric

2023-02-13 Thread via GitHub
jsancio commented on code in PR #13207: URL: https://github.com/apache/kafka/pull/13207#discussion_r1105042885 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -232,6 +232,32 @@ public void shouldRecordPollIdleRatio() {

[GitHub] [kafka] jsancio commented on a diff in pull request #13207: KAFKA-14664; Fix inaccurate raft idle ratio metric

2023-02-08 Thread via GitHub
jsancio commented on code in PR #13207: URL: https://github.com/apache/kafka/pull/13207#discussion_r1100891108 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix,

[GitHub] [kafka] jsancio commented on a diff in pull request #13207: KAFKA-14664; Fix inaccurate raft idle ratio metric

2023-02-07 Thread via GitHub
jsancio commented on code in PR #13207: URL: https://github.com/apache/kafka/pull/13207#discussion_r1098994575 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix,