[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

2022-06-07 Thread GitBox
jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1148986153 @dengziming I merged KAFKA-13916. When you have sometime can you take a look at this change again? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

2022-06-06 Thread GitBox
jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1147912524 We need to make sure that we handle these changes depending on which commit gets merged first: https://github.com/apache/kafka/pull/12240/commits/db8224767457c79e8af31af0b4ddbd9988

[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

2022-06-03 Thread GitBox
jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1146366630 @dengziming I merge `trunk` to try to kick off a build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

2022-06-02 Thread GitBox
jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1145057898 @dengziming Thanks for improving this! There are a lot of test failures. Can you take a look at those? -- This is an automated message from the Apache Git Service. To respond to the mes