jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817901760
Interesting. When I run the rat task locally, those three files are
identified (correctly) as binary files and RAT skips them.
I'm not sure why they are being detected as
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817844704
> @jthurne This change causes new failures:
Indeed. Unfortunately, I have been unable to reproduce them locally. One
downside to the RAT plugin is that it doesn't output
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814950598
I believe the license failures were caused by a different change to trunk
that has since been fixed. I merged the latest trunk HEAD into this PR to
re-trigger CI.
--
This is
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814916880
I'm looking into the build failures on this one.
At first glance, the pr-merge build failed due to one of the test tasks
crashing. Presumably that's not related at all to
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814378302
Full disclosure: I'm an engineer that works for Gradle (on [Gradle
Enterprise](https://gradle.com/), and I found these optimizations while using
the project to test out Gradle
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814377383
@ijuma another one for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
