[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164633122 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164488222 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164476174 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164445859 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164424805 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164392731 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1163446164 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1163287233 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161909242 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147813111 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit =

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147794328 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit =

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147689005 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit =

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1146944915 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -35,6 +36,40 @@ trait ApiRequestHandler { def handle(request: RequestChannel.Request,

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1145545834 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1145487679 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1145453181 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1144090231 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2432,7 +2440,7 @@ class KafkaApis(val requestChannel: RequestChannel, txns.forEach { transaction =>