[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

2023-04-03 Thread via GitHub
junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156467464 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -59,8 +61,9 @@ object TransactionCoordinator { time, metrics) val

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

2023-04-03 Thread via GitHub
junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156467080 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

2023-04-03 Thread via GitHub
junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156466725 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

2023-03-31 Thread via GitHub
junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1154881426 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =