[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-19 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1330455761 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327744776 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -298,8 +289,8 @@ private void onFailure(final long currentTimeMs,

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327568639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-14 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326612426 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325040397 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -91,7 +89,7 @@ public CommitRequestManager( } /** -