[GitHub] [kafka] kamalcph commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-15 Thread via GitHub
kamalcph commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1295402786 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1003,6 +1015,134 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-15 Thread via GitHub
kamalcph commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1295394486 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void

[GitHub] [kafka] kamalcph commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-14 Thread via GitHub
kamalcph commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1293158752 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1003,6 +1015,134 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-14 Thread via GitHub
kamalcph commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1293081560 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void

[GitHub] [kafka] kamalcph commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-14 Thread via GitHub
kamalcph commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1293081560 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void