kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1697195615
> Finally had a pass, left some comments. Thanks again for the effort to put
all these test framework!
Credits to @Hangleton for coming up with this framework!
--
This is an
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1682062995
How to fix the below error in the test? The test is currently marked as
DISABLED but still fails with below error, there are some left-over threads:
Build / JDK 11 and Scala 2.13
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1681581185
@satishd
Can you please take a look when you get chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1681198112
@showuon
Call for review. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1679001860
@divijvaidya
Addressed most of your comments and marked them as resolved. Please take a
look that those comments are addressed as expected. Thanks!
--
This is an automated
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1668144105
> This leads to a situation where the tests we add will not be runnable with
kraft/zk mode easily.
We are not using ZooKeeper client directly anywhere so Kraft mode should
work
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1666869894
@clolov @divijvaidya @showuon @Hangleton @satishd
1. This PR contains huge changes but most of them are new POJO classes and
specific actions. My suggestion is to review all the
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1661973903
> Hello and thank you for starting on this ! What is your plan when it
comes to reviewing this code - will you be splitting it into multiple pull
requests for individual
