[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461888 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -522,7 +525,35 @@ public void subscribe(Collection topics,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461556 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -537,7 +568,9 @@ public void subscribe(Pattern pattern) {

[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461234 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -522,7 +525,35 @@ public void subscribe(Collection topics,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223460895 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -522,7 +525,35 @@ public void subscribe(Collection topics,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223460709 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -106,4 +114,17 @@ private boolean process(final

[GitHub] [kafka] kirktrue commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

kirktrue commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1223454138 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -106,4 +114,17 @@ private boolean process(final