[GitHub] [kafka] kirktrue commented on pull request #13211: KAFKA-14676: Include all SASL configs in login cache key to ensure clients in a JVM can use different OAuth configs

Tue, 07 Feb 2023 10:26:29 -0800 


kirktrue commented on PR #13211:
URL: https://github.com/apache/kafka/pull/13211#issuecomment-1421255523

   @rajinisivaram - LGTM.
   
   It took me a second to verify that the `configs` that was passed into the 
`LoginMetadata ` wasn't being used directly in the `hashCode` and `equals` 
methods.
   
   Thanks for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to