[GitHub] [kafka] kirktrue commented on pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

2023-03-09 Thread via GitHub
kirktrue commented on PR #13301: URL: https://github.com/apache/kafka/pull/13301#issuecomment-1462812863 @guozhangwang I've added some dedicated unit tests. Keep in mind that these classes are all still used by the `Fetcher` and thus the extensive `FetcherTest` class covers them too. When r

[GitHub] [kafka] kirktrue commented on pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

2023-03-02 Thread via GitHub
kirktrue commented on PR #13301: URL: https://github.com/apache/kafka/pull/13301#issuecomment-1452775886 @guozhangwang wrote: > A meta comment is that for the extracted classes, I think we should add unit test coverages for them (hopefully most of them are already in the `FetcherTest

[GitHub] [kafka] kirktrue commented on pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

2023-02-24 Thread via GitHub
kirktrue commented on PR #13301: URL: https://github.com/apache/kafka/pull/13301#issuecomment-1444580426 @hachikuji @rajinisivaram @guozhangwang @vvcephei @philipnee This is another PR that "simply" refactors out the inner classes from the `Fetcher`. I broke it out into a separate PR becaus