[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421189122 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421188159 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421005156 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420895742 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void