[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656397814 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest { assertTrue(onlySegment.lazyOffs

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656397814 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest { assertTrue(onlySegment.lazyOffs

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655768001 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition: TopicParti

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655823904 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: TopicParti

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655788102 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest { assertTrue(onlySegment.lazyOffs

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655768001 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition: TopicParti

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r654224850 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2390,16 +2390,23 @@ object Log extends Logging { produ