[GitHub] [kafka] kowshik commented on pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-808012495 @junrao Thanks a lot for the review! I've addressed your comments in 63be325b8b3ff5514e22137bb02dfc70e10f7a72. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kowshik commented on pull request #10280: KIP-405: Log layer refactor

2021-03-09 Thread GitBox
kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-794673540 @ijuma I've opened up the doc for comments. I've also updated it to use the name `UnifiedLog` instead of `GlobalLog`. Hopefully the intent is better communicated now in the

[GitHub] [kafka] kowshik commented on pull request #10280: KIP-405: Log layer refactor

2021-03-09 Thread GitBox
kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-794226594 @ijuma The purpose of `GlobalLog` class is to serve as a higher layer, stitching together the unified view of both the local and remote portion of the log. Importantly, this

[GitHub] [kafka] kowshik commented on pull request #10280: KIP-405: Log layer refactor

2021-03-09 Thread GitBox
kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-794210868 @ijuma In this PR the intention was not to rename `Log` to `LocalLog`, but rather extract `LocalLog` class out of `Log`. My current plan is to do the alternative of what you