[GitHub] [kafka] kowshik commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-26 Thread GitBox
kowshik commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767406004 @chia7712 Good point. My understanding is that iteration over `ConcurrentSkipListMap.values()` is weakly consistent, which seems good enough for this case. But since my intention

[GitHub] [kafka] kowshik commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-26 Thread GitBox
kowshik commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767390605 @chia7712: Going by the documentation, the results of the iteration are undefined if the map is modified while an iteration over the collection is in progress. IIUC we would end

[GitHub] [kafka] kowshik commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-25 Thread GitBox
kowshik commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767252255 cc @junrao for review This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kowshik commented on pull request #9971: MINOR: Cache segments map only when required in Log.fetchOffsetByTimestamp

2021-01-25 Thread GitBox
kowshik commented on pull request #9971: URL: https://github.com/apache/kafka/pull/9971#issuecomment-767252255 cc @junrao for review This is an automated message from the Apache Git Service. To respond to the message, please