[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1334676439 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333628852 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333583458 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333212830 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333187091 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333166590 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333144301 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1333122605 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberAssignmentReconciler.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software