[GitHub] [kafka] lianetm commented on a diff in pull request #14413: KAFKA-15275 [2/N]: Client state machine improvements

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r124044 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -19,56 +19,91 @@ import

[GitHub] [kafka] lianetm commented on a diff in pull request #14413: KAFKA-15275 [2/N]: Client state machine improvements

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r121553 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -19,56 +19,91 @@ import

[GitHub] [kafka] lianetm commented on a diff in pull request #14413: KAFKA-15275 [2/N]: Client state machine improvements

2023-09-21 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r114252 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -19,56 +19,91 @@ import

[GitHub] [kafka] lianetm commented on a diff in pull request #14413: KAFKA-15275 [2/N]: Client state machine improvements

2023-09-20 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1332210545 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -149,92 +212,84 @@ private boolean maybeTransitionToStable() {