[GitHub] [kafka] lihaosky commented on a diff in pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-07-21 Thread GitBox
lihaosky commented on code in PR #12166: URL: https://github.com/apache/kafka/pull/12166#discussion_r927167240 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -226,9 +226,10 @@ private void emitNonJoinedOuterRecords(

[GitHub] [kafka] lihaosky commented on a diff in pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-07-21 Thread GitBox
lihaosky commented on code in PR #12166: URL: https://github.com/apache/kafka/pull/12166#discussion_r927166898 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -333,6 +352,87 @@ public void shouldJoinWithCustomStoreSuppliers(